Skip to content

Driver: honour -no-toolchain-stdlib-rpath on Unices #30430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2020
Merged

Driver: honour -no-toolchain-stdlib-rpath on Unices #30430

merged 1 commit into from
Mar 18, 2020

Conversation

@compnerd
Copy link
Member

@compnerd compnerd commented Mar 16, 2020

Handle -no-toolchain-stdlib-rpath on Linux/android as well as Darwin. This
enables the flags on other Unix platforms as it can be useful to control the
embedded rpath for the library.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

compnerd commented Mar 16, 2020

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

swift-ci commented Mar 16, 2020

Build failed
Swift Test Linux Platform
Git Sha - ccd96a0f770cbbf1bb162515bf43907fefe94a4b

@finagolfin
Copy link
Member

finagolfin commented Mar 17, 2020 •
edited
Loading

This is a little better than my previous similar attempt in #30235 as it gets rid of shouldProvideRPathToLinker and -no-toolchain-stdlib-rpath is more descriptive (though it works the same as -no-stdlib-rpath on Unix), but my commit had some tests. Maybe you could adapt the macOS tests for these flags in linker-rpath.swift to run on Unix too.

@compnerd
Copy link
Member Author

compnerd commented Mar 17, 2020

This cannot go in without tests. I just wanted to run the test suite since I saw some of failures locally.

I guess I should’ve made it a draft, but I keep forgetting about the functionality.

Thanks for the pointer though, should make things easier.

@compnerd
Driver: honour -no-toolchain-stdlib-rpath on Unices
c7a198b 
Handle `-no-toolchain-stdlib-rpath` on Linux/android as well as Darwin.  This
enables the flags on other Unix platforms as it can be useful to control the
embedded rpath for the library.
@compnerd
Copy link
Member Author

compnerd commented Mar 17, 2020

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Mar 17, 2020

@swift-ci please test Windows platform

@compnerd
Copy link
Member Author

compnerd commented Mar 17, 2020

CC: @gottesmm @tomerd

finagolfin
finagolfin approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@finagolfin finagolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove my equivalent commit in #30235 once this is in.

@compnerd compnerd merged commit 2c1c13d into swiftlang:master Mar 18, 2020
@compnerd compnerd deleted the rpath branch March 18, 2020 02:14
@finagolfin finagolfin mentioned this pull request Mar 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@finagolfin finagolfin finagolfin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@compnerd @swift-ci @finagolfin